Use fs.rm() instead of rimraf

[kevinoid]

A regression occurred in 0.2.2 which can be reproduced using:

const assert = require('assert');
const tmp = require('tmp');
tmp.dir({ unsafeCleanup: true }, (err, path, cleanup) => {
  assert.ifError(err);
  cleanup(assert.ifError);
});

This works with 0.2.1. With 0.2.2 it fails with:

/path/to/tmp/node-tmp/lib/tmp.js:358
        return removeFunction(fileOrDirName, next || function() {});
               ^

TypeError: removeFunction is not a function
    at _cleanupCallback (/path/to/tmp/node-tmp/lib/tmp.js:358:16)
    at /path/to/tmp/node-tmp/repro.js:5:3
    at _dirCreated (/path/to/tmp/node-tmp/lib/tmp.js:207:7)
    at FSReqCallback.oncomplete (node:fs:192:23)

This occurs because 00bb5b2 upgraded the rimraf dependency from ^3.0.0 to ^5.0.5 without handling the change to a Promise-based API in 4.0.0 (isaacs/rimraf@a71e7f9) or the removal of the default export in 5.0.0 (isaacs/rimraf@c7a3fd4).

This commit fixes the issue by dropping the rimraf dependency in favor of fs.rm({recursive: true}).

Thanks for considering,
Kevin

Fixes: #295

[raszi]

Looks good! Thank you very much!

[raszi]

I believe the tests need to be updated as well.

[kevinoid]

My pleasure. Thanks for reviewing it @raszi.

I believe the tests need to be updated as well.

Whoops! Right you are. Sorry I missed that.

I've pushed a new version which updates the tests, package-lock.json, and the docs. Let me know if I've missed anything else.

P.S. How do you feel about support for Node.js 14.0 to 14.14 (when fs.rm() was added)? I have a fallback from fs.rm() to fs.rmdir() in lib/tmp.js to support <14.14, but didn't bother in the tests, since CI doesn't run it. Would it make sense to drop support for Node.js < 14.14, or to test it and add a CI job?

[raszi]

I don't mind dropping that it isn't supported anymore:

https://nodejs.org/en/about/previous-releases

[kevinoid]

Sounds good to me. I've dropped the fs.rmdir fallback to simplify the code a bit. Let me know if there are any other changes you'd like.

[kevinoid]

Note: I just pushed an update to generate package-lock.json with npm from Node 14 to fix the CI error.

[raszi]

Nice work! Thank you very much!