Skip to content

Commit

Permalink
btrfs: cow_file_range() num_bytes and disk_num_bytes are same
Browse files Browse the repository at this point in the history
[ Upstream commit 3752d22fcea160cc2493e34f5e0e41cdd7fdd921 ]

This patch deletes local variable disk_num_bytes as its value
is same as num_bytes in the function cow_file_range().

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
asj authored and ratatouille100 committed Nov 27, 2023
1 parent ecbc13c commit 4614ab7
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions fs/btrfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,6 @@ static noinline int cow_file_range(struct inode *inode,
u64 alloc_hint = 0;
u64 num_bytes;
unsigned long ram_size;
u64 disk_num_bytes;
u64 cur_alloc_size = 0;
u64 blocksize = fs_info->sectorsize;
struct btrfs_key ins;
Expand All @@ -996,7 +995,6 @@ static noinline int cow_file_range(struct inode *inode,

num_bytes = ALIGN(end - start + 1, blocksize);
num_bytes = max(blocksize, num_bytes);
disk_num_bytes = num_bytes;

inode_should_defrag(BTRFS_I(inode), start, end, num_bytes, SZ_64K);

Expand All @@ -1023,15 +1021,14 @@ static noinline int cow_file_range(struct inode *inode,
}
}

BUG_ON(disk_num_bytes >
btrfs_super_total_bytes(fs_info->super_copy));
BUG_ON(num_bytes > btrfs_super_total_bytes(fs_info->super_copy));

alloc_hint = get_extent_allocation_hint(inode, start, num_bytes);
btrfs_drop_extent_cache(BTRFS_I(inode), start,
start + num_bytes - 1, 0);

while (disk_num_bytes > 0) {
cur_alloc_size = disk_num_bytes;
while (num_bytes > 0) {
cur_alloc_size = num_bytes;
ret = btrfs_reserve_extent(root, cur_alloc_size, cur_alloc_size,
fs_info->sectorsize, 0, alloc_hint,
&ins, 1, 1);
Expand Down Expand Up @@ -1097,11 +1094,10 @@ static noinline int cow_file_range(struct inode *inode,
delalloc_end, locked_page,
EXTENT_LOCKED | EXTENT_DELALLOC,
page_ops);
if (disk_num_bytes < cur_alloc_size)
disk_num_bytes = 0;
if (num_bytes < cur_alloc_size)
num_bytes = 0;
else
disk_num_bytes -= cur_alloc_size;
num_bytes -= cur_alloc_size;
num_bytes -= cur_alloc_size;
alloc_hint = ins.objectid + ins.offset;
start += cur_alloc_size;
extent_reserved = false;
Expand Down

0 comments on commit 4614ab7

Please sign in to comment.