Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.4] Bump minimum PHP to 7.4 #55

Merged
merged 1 commit into from
Dec 10, 2021
Merged

[0.4] Bump minimum PHP to 7.4 #55

merged 1 commit into from
Dec 10, 2021

Conversation

mbabker
Copy link

@mbabker mbabker commented Dec 6, 2021

Unblocks #51

Based on https://packagist.org/packages/ratchet/rfc6455/php-stats#0.3 it would cover 75% of active consumers of this library (with PHP 7.2 and 7.3 being another 20% combined).

@cboden cboden self-requested a review December 6, 2021 22:47
@cboden cboden added this to the 0.4 milestone Dec 6, 2021
@cboden
Copy link
Member

cboden commented Dec 6, 2021

Given https://www.php.net/supported-versions.php I was even considering requiring 7.4. With v0.3.* keeping really old BC compatibility with a few updates soon, I'd be ok with making a bigger jump for v0.4.

Thoughts?

@mbabker
Copy link
Author

mbabker commented Dec 6, 2021

That works too. Originally I was going to jump straight to 7.4, but there's still a sizeable chunk of users on 7.2 and 7.3 so I broadened it just a bit.

@mbabker mbabker changed the title [0.4] Bump minimum PHP to 7.2 [0.4] Bump minimum PHP to 7.4 Dec 6, 2021
@cboden cboden changed the base branch from master to v0.4 December 9, 2021 23:56
@cboden
Copy link
Member

cboden commented Dec 9, 2021

Thanks Michael. I re-targeted against the v0.4 branch. There's a conflict since we corrected some stuff for v0.3.1.

Shall we drop Guzzle 1 support?

@mbabker
Copy link
Author

mbabker commented Dec 10, 2021

There's a conflict since we corrected some stuff for v0.3.1.

That's fixed.

Shall we drop Guzzle 1 support?

I wouldn't just yet. The 1.8 branch just got a new release a couple of months ago and the 1.x installs are still 2:1 over the 2.x installs, so it sounds like the long tail of consumers of that package might take a little while to catch up on it.

@cboden
Copy link
Member

cboden commented Dec 10, 2021

That works too. Originally I was going to jump straight to 7.4, but there's still a sizeable chunk of users on 7.2 and 7.3 so I broadened it just a bit.

v0.3.1 can still be used by users who are using unsupported versions.

@cboden cboden merged commit 02dca5e into ratchetphp:v0.4 Dec 10, 2021
@mbabker mbabker deleted the patch-1 branch December 10, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants