Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dangerous buttons to password protected area #235

Closed
JKaniarz opened this issue Sep 18, 2024 · 5 comments
Closed

Move dangerous buttons to password protected area #235

JKaniarz opened this issue Sep 18, 2024 · 5 comments

Comments

@JKaniarz
Copy link

I'd like to see the Firmware Update, Un-pair HomeKit, and Reboot buttons moved to the password protected page. Those are "admin" level features that could be used to covertly break into the house. (the other buttons are fine because they generate notifications)

@dkerr64
Copy link
Collaborator

dkerr64 commented Sep 19, 2024

Firmware updates and re-pairing are already password protected... if you are not seeing the prompt then it is because browsers cache credentials and only request userid/password if credentials expire or change. Those and reboot are also wrapped with a "are you sure" popup.

Reboot is not password protected. This was a conscious decision as reboot is non-destructive, it takes ~30 seconds to reboot and re-connect to the Apple Home network.

@JKaniarz
Copy link
Author

I'm glad to hear it's secure, but it's not obvious that it is. I knew to test in incognito mode, but I wasn't expecting the password prompt to be after the point of no return. I assumed that "are you sure" meant there were no further guardrails.

Will you consider showing the password prompt right after the first click for the firmware and unpair buttons to make it more obvious?

@dkerr64
Copy link
Collaborator

dkerr64 commented Sep 19, 2024

Yes, let me check that, we can change to do the credentials check before the are you sure pop up.

Thanks for the suggestion.

dkerr64 added a commit to dkerr64/homekit-ratgdo that referenced this issue Sep 19, 2024
@dkerr64
Copy link
Collaborator

dkerr64 commented Sep 19, 2024

I have made this change in PR #227 so will be included in next release.

@dkerr64
Copy link
Collaborator

dkerr64 commented Sep 23, 2024

fixed in v1.7.1

@dkerr64 dkerr64 closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants