README: rauc-conf needs to be appended now instead of rauc #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With d51bab8 (rauc: split package into 'rauc' for binary and 'rauc-conf' for configuration), users need to append rauc-conf instead of rauc when providing their device-specific configuration. This was not reflected by the docs yet. Also add an explicit migration note early in the README.rst. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
jluebbe
approved these changes
Jun 18, 2024
OnkelUlla
requested changes
Jun 18, 2024
| @@ -17,8 +17,8 @@ To use them in your BSP in order to sign and verify bundles, you have to: | |||
|
|
|||
| Copy the keyring file `dev/ca.cert.pem` into your projects meta layer under | |||
| `recipes-core/rauc/files` and add a simple rauc .bbappend file | |||
There was a problem hiding this comment.
Formally in line 19 this should be "and add a simple rauc-conf .bbappend file", perhaps it would be better to just drop the first part and use "and add a simple .bbappend file" instead.
There was a problem hiding this comment.
👍 I would be fine with both variants. Since the PR was merged a minute before your comment, feel free to open a new one with this additional fix.
There was a problem hiding this comment.
Done and already merged.
OnkelUlla
added a commit
that referenced
this pull request
Jun 18, 2024
Fix small leftover of PR #327
|
backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With d51bab8 (rauc: split package into 'rauc' for binary and 'rauc-conf' for configuration), users need to append rauc-conf instead of rauc when providing their device-specific configuration.
This was not reflected by the docs yet.
Also add an explicit migration note early in the README.rst.