hawkbit-client: do not pass NULL format to g_strdup_vprintf() in build_api_url() #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bastian-Krause
force-pushed
the
bst/fix-build-api-url
branch
from
bdb4cbe to
082440d
Compare
|
Force-pushed:
|
…d_api_url() build_api_url() can be called with NULL to get the base deployment URL. Passing NULL as a format argument to g_strdup_vprintf() returns NULL if GLIB_USING_SYSTEM_PRINTF is defined, otherwise it leads to a segmentation fault. The format argument is explicitly documented as "not nullable", so we rely on undefined behavior here. Skip over va_start(), g_strdup_vprintf(), va_end() for path=NULL to fix that. Signed-off-by: Bastian Krause <bst@pengutronix.de>
Bastian-Krause
force-pushed
the
bst/fix-build-api-url
branch
from
082440d to
439feee
Compare
ejoerns
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_api_url()can be called withNULLto get the base deployment URL. PassingNULLas a format argument tog_strdup_vprintf()returnsNULLifGLIB_USING_SYSTEM_PRINTFis defined, otherwise it leads to a segmentationfault. The format argument is explicitly documented as "not nullable", so we rely on undefined behavior here.
Skip over
va_start(),g_strdup_vprintf(),va_end()forpath=NULLto fix that.