test: read output of process until EOF #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests run various processes, such as rauc-hawkbit-updater, nginx or rauc_dbus_dummy. The output of these processes is currently only read until we see the string/regex we expect. Everything else is not read and does not end up in the logs. This is confusing to the person running the tests, because errors, tracebacks and other output the tests do not rely on is not logged. To change this, read all relevant process output (until EOF) after the processes are terminated. Signed-off-by: Bastian Krause <bst@pengutronix.de>
This unused variable was there since the introduction of the Python test suite. It is a relict of a prior implementation. Fixes: a5fc698 ("test: add basic tests") Signed-off-by: Bastian Krause <bst@pengutronix.de>
ejoerns
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests run various processes, such as rauc-hawkbit-updater, nginx or rauc_dbus_dummy. The output of these processes is currently only read until we see the string/regex we expect. Everything else is not read and does not end up in the logs.
This is confusing to the person running the tests, because errors, tracebacks and other output the tests do not rely on is not logged.
To change this, read all relevant process output (until
EOF) after the processes are terminated.While at it, drop an unused line from conftest. It was there since the introduction of the Python test suite. It is a relict of a prior implementation.