Support Installation-Date-based Slot Selection (A/B/C Update) #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejoerns
added
the
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1525 +/- ##
==========================================
+ Coverage 83.24% 83.27% +0.02%
==========================================
Files 69 69
Lines 21585 21632 +47
==========================================
+ Hits 17968 18013 +45
- Misses 3617 3619 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ejoerns
changed the title
jluebbe
requested changes
Oct 23, 2024
| GHashTableIter iter; | ||
|
|
||
| g_return_val_if_fail(rootclass, NULL); | ||
|
|
||
| if (g_strcmp0(r_context()->config->statusfile_path, "per-slot") == 0) { | ||
| g_debug("Selecting inactive slot for class '%s'. Fallback strategy: 'first found'", rootclass); |
There was a problem hiding this comment.
Suggested change
| g_debug("Selecting inactive slot for class '%s'. Fallback strategy: 'first found'", rootclass); | |
| g_debug("Selecting inactive slot for class '%s'. Strategy: 'first found'", rootclass); |
| return iterslot; | ||
| } | ||
|
|
||
| g_assert_nonnull(iterslot->status); |
There was a problem hiding this comment.
Is this guaranteed? What happens if the global slot status is empty?
Comment on lines
+372
to
+378
| gchar *found = g_date_time_format(iterslot->status->installed_timestamp, RAUC_FORMAT_ISO_8601); | ||
| gchar *current = g_date_time_format(selectslot->status->installed_timestamp, RAUC_FORMAT_ISO_8601); |
Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
When using a global slot status, we can load the status of all slots during RAUC startup. This should happen during (target) context setup. This commit does not change behavior but renames load_slot_status_globally() to r_slot_status_load_globally() and adds the status file name and slot hash table as arguments to allow removing calls to the r_context() method (which is not available during context setup). Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Adds a call to r_slot_status_load_globally() to r_context_configure_target(), just like it already calls r_system_status_load(). This ensures the slot status is loaded initially and the rest of the code can safely assume the status information is filled (when using a global status file). Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Prepares for reworking timestamp handling and ensures using the same format string consistently. For later glib versions, an alternative coulde be to use g_date_time_format_iso8601(). Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Up to now the time was stored as a gchar string in RaucSlotStatus as it was only recorded and never modified or used for any operation. If we now aim to use this time to base further decisions on it, we should be able to properly handle the time as time and not as a string. Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
…date) So far, RAUC theoretically supported having three slot groups (e.g. rootfs.0, rootfs.1, rootfs.2), but the slot selection algorithm prevented their use for an A/B/C update. The algorithm simply selected the 'first' inactive slot group. The 'first' group is implementation-defined by the data type used (i.e. by the GHashTable). As a result, updating always alternated between two slot groups. This commit now introduces a slightly more sophisticated slot selection algorithm which always selects the slot group with the oldest installation date. Selecting the oldest installation date automatically ensures that all slots get their turn since once a slot is updated, it has the most recent timestamp and will be selected last. A slot that has no installation date yet is considered outdated. Not that the same behavior can also be used in an A/B setup together with 'rauc.external' to ensure that two consecutive calls of 'rauc install' populate *both* inactive slot groups A and B. Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Having a data-directory is the new default, thus we should update older configs to this. It also potentially enhances test coverage for data-directory and allows using it for testing newer features. Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
The crypt-test.conf should was meant to be used for the crypt tests. Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
With the changes made for timestamp-based slot selection, it is possible to install to both inactive slot groups by calling 'rauc install' twice. This extends the existing test case 'test_install_rauc_external' to cover that, too. Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
ejoerns
force-pushed
the
topic/abc-update
branch
from
73bf8fc
to
8143d3f
Compare
|
Rebased onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, RAUC theoretically supported having three slot groups (e.g.
rootfs.0,rootfs.1,rootfs.2), but the slot selection algorithm prevented their use for an A/B/C update.The algorithm simply selected the 'first' inactive slot group.
The 'first' group is implementation-defined by the data type used (i.e. by the GHashTable).
As a result, updating always alternated between two slot groups.
This PR now introduces a slightly more sophisticated slot selection algorithm which always selects the slot group with the oldest installation date.
Selecting the oldest installation date automatically ensures that all slots get their turn since once a slot is updated, it has the most recent timestamp and will be selected last.
A slot that has no installation date yet is considered outdated.
Not that the same behavior can also be used in an A/B setup together with
rauc.externalto ensure that two consecutive calls ofrauc installpopulate both inactive slot groups A and B.Fixes #1383