Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/tests: upload coverage separately for service=true/false #1540

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jluebbe
Copy link
Member

@jluebbe jluebbe commented Oct 21, 2024

This allows codecov to show the coverage for each case separately.

…false

This allows codecov to show the coverage for each case separately.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
@jluebbe jluebbe added this to the Release v1.13 milestone Oct 21, 2024
@jluebbe jluebbe requested a review from ejoerns October 21, 2024 09:19
@jluebbe
Copy link
Member Author

jluebbe commented Oct 21, 2024

You can see the resulting output at: https://app.codecov.io/gh/jluebbe/rauc/tree/codecov-flags

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.24%. Comparing base (1ba909b) to head (191e4c9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1540   +/-   ##
=======================================
  Coverage   83.24%   83.24%           
=======================================
  Files          69       69           
  Lines       21585    21585           
=======================================
  Hits        17968    17968           
  Misses       3617     3617           
Flag Coverage Δ
service=false 80.06% <ø> (?)
service=true 83.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ejoerns ejoerns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet fully sure what to do with the results (since service-only paths can be followed by service tests, only) but looks interesting anyway.

@ejoerns ejoerns merged commit ccdffd2 into rauc:master Oct 23, 2024
19 checks passed
@jluebbe jluebbe deleted the codecov-flags branch October 23, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants