Apply suggestions from code review

Co-authored-by: Antoine Pitrou <pitrou@free.fr>

python/pyarrow/tests/test_csv.py

@@ -66,7 +66,8 @@ def split_columns(arr, num_cols, num_rows):
 
 
 def make_random_csv(num_cols=2, num_rows=10, linesep='\r\n', write_names=True):
- arr = [random.randint(0, 1000) for _ in range(num_cols * num_rows)]
+ rnd = random.Random(42)
+ arr = [rnd.randint(0, 1000) for _ in range(num_cols * num_rows)]
  csv = io.StringIO()
  col_names = list(itertools.islice(generate_col_names(), num_cols))
  if write_names:

python/pyarrow/tests/test_types.py

@@ -1264,10 +1264,10 @@ def test_field_modified_copies():
  assert f0.equals(f0_)
 
 
-@pytest.mark.numpy
 def test_is_integer_value():
  assert pa.types.is_integer_value(1)
- assert pa.types.is_integer_value(np.int64(1))
+ if np is not None:
+ assert pa.types.is_integer_value(np.int64(1))
  assert not pa.types.is_integer_value('1')
 
 

python/pyarrow/tests/util.py

@@ -109,8 +109,7 @@ def randdecimal(precision, scale):
 
 
 def random_ascii(length):
- import numpy as np
- return bytes(np.random.randint(65, 123, size=length, dtype='i1'))
+ return bytes([random.randint(65, 122) for i in range(length)])
 
 
 def rands(nchars):