Skip to content

Issue 13/remove parquet extension check#21

Merged
raulcd merged 5 commits intoraulcd:mainfrom
jacopoprandelli:issue-13/remove-parquet-extension-check
Nov 14, 2025
Merged

Issue 13/remove parquet extension check#21
raulcd merged 5 commits intoraulcd:mainfrom
jacopoprandelli:issue-13/remove-parquet-extension-check

Conversation

@jacopoprandelli
Copy link
Contributor

Remove file extension validation for Parquet files

Summary

Removes the requirement for files to have a .parquet extension. The application now validates files based on their actual content rather than their file extension.

Changes

  • CLI: Removed file extension check - now accepts any file path
  • ParquetReader: Enhanced validation to check file existence and let PyArrow validate the actual Parquet format
  • Tests: Updated and added tests to cover:
    • Files without .parquet extension -> test_reader_accepts_file_without_parquet_extension
    • Invalid (non-Parquet) files -> test_reader_invalid_parquet_file
    • File not found errors -> test_reader_nonexistent_file

Closes #13

Copy link
Owner

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the PR!

@raulcd raulcd merged commit c0adad6 into raulcd:main Nov 14, 2025
2 checks passed
@jacopoprandelli jacopoprandelli deleted the issue-13/remove-parquet-extension-check branch November 14, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unnecessary check for .parquet extension

3 participants