Refactor DataTab to use scrollable DataTable for data preview#24
Merged
raulcd merged 2 commits intoraulcd:mainfrom Nov 15, 2025
Merged
Conversation
raulcd
reviewed
Nov 14, 2025
Owner
raulcd
left a comment
There was a problem hiding this comment.
To be honest I plan to do quite a big overhaul of the initially hacked TUI to make it more composable. I'll take a look at your PR once I have some time and will probably merge it but then I'll refactor. For example there's quite a lot of logic on this module that doesn't belong here and should live in the reader.
Contributor
Author
|
Yeah it makes sense. Thanks for the great tool! |
raulcd
reviewed
Nov 14, 2025
Owner
raulcd
left a comment
There was a problem hiding this comment.
Thanks again for the PR. As suggested I plan to refactor the tui soon but I'll base it on your work here. Thanks for the changes!
Just a small nit about some of the attributes which doesn't seem strictly necessary when creating a DataTable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the Rich
Tablepreview with Textual’sDataTable, wrapping it inHorizontalScrollso wide Parquet schemas stay accessible while preserving formatting. This is just one possible implementation.Changes
_create_data_tableto build a TextualDataTable(cursor support, zebra stripes, border styling, NULL highlighting).min_widthand wrap the widget inHorizontalScrollinsidecomposeso wide schemas remain accessible.Staticerror/empty states through the Textual compose API to match the new widget structure.Closes #23