Features/sorvkumr/complete controller methods #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raulshma
requested changes
Jun 22, 2023
| var ret = await _designationService.InsertAsync(value); | ||
| if(ret != null) { return TypedResults.Ok(ret); } | ||
| return null; | ||
| if (value?.Name != "") |
There was a problem hiding this comment.
Can we use string.IsNullOrEmpty.
| var ret = await _designationService.UpdateAsync(value); | ||
| if(ret != null) { return TypedResults.Ok(ret); } | ||
| return null; | ||
| if (value?.Name != "") |
There was a problem hiding this comment.
Can we use string.IsNullOrEmpty.
| { | ||
| foreach (var item in items) | ||
| { | ||
| var projectResult = _projectService.GetAsync(item.ProjectId)?.Result; |
| IEnumerable<Module> items = await _repository.GetAsync(); | ||
| if (items.Any()) | ||
| { | ||
| foreach (var item in items) |
There was a problem hiding this comment.
Instead of doing this can we use the navigation property, if we have one.
|
|
||
| public async Task<ModuleResponse?> GetByIdAsync(Guid? id) | ||
| { | ||
| var item = await _repository.GetByIDAsync(id); |
There was a problem hiding this comment.
Instead of doing 2 queries, can we use a join.
| if (ret != null) | ||
| { | ||
| await _repository.SaveChangesAsync(); | ||
| var projectVal = _projectService.GetAsync(ret.ProjectId).Result; |
| if (result != null) | ||
| { | ||
| await _repository.SaveChangesAsync(); | ||
| var projectVal = _projectService.GetAsync(result.ProjectId).Result; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add crud for the Module. Review and added checks in the Designation controller.