Skip to content
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.

Change from alpine to ubuntu in Dockerfile.default #60

Merged
merged 3 commits into from
Aug 26, 2023
Merged

Change from alpine to ubuntu in Dockerfile.default #60

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2308b9a
Change from alpine to ubuntu in dockerfile.default
nvtienanh Aug 26, 2023
20b1460
Using GGML_STATIC
nvtienanh Aug 26, 2023
3e37c4b
Update cmake command
nvtienanh Aug 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions Dockerfile.default
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,24 @@
FROM alpine AS build
FROM ubuntu:22.04 AS build

RUN apk add --update alpine-sdk boost-dev cmake asio-dev
ENV DEBIAN_FRONTEND=noninteractive

ADD ./ /turbopilot/
# inlude kitware apt repo to allow us to grab latest cmake
RUN apt-get update && apt-get install -y ca-certificates gpg wget
RUN wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | tee /usr/share/keyrings/kitware-archive-keyring.gpg >/dev/null
RUN echo 'deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ jammy main' | tee /etc/apt/sources.list.d/kitware.list >/dev/null

RUN apt-get update && apt-get install -y build-essential cmake libboost-dev libboost-thread-dev

ADD ./ /turbopilot

RUN mkdir /turbopilot/build

WORKDIR /turbopilot/build

RUN cmake -D GGML_STATIC=ON ..
RUN cmake -DGGML_OPENBLAS=ON ..
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a significant change - I do not want to enable openblas by default for the normal docker image as OpenBlas support is still unstable and is not guaranteed to speed up computation for all models and users.

If we're shipping with ubuntu there's no advantage to having a static build either so I think this line should be

RUN cmake ..

I am open to adding an openblas flavour of the docker build to the CI as well. I might simplify the docker build process and use a single file with different docker build args.

RUN make turbopilot

FROM alpine AS runtime
FROM ubuntu:22.04 AS runtime


WORKDIR /app
Expand Down