parser error for invalid : after imports (JuliaLang#34694)

ravibitsgoa · Apr 6, 2020 · 04e88a1 · 04e88a1
1 parent 15d6937
commit 04e88a1
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/src/julia-parser.scm b/src/julia-parser.scm
@@ -1577,8 +1577,13 @@
  (else #t)))
  (rest (if done
  '()
- (parse-comma-separated s (lambda (s)
- (parse-import s word))))))
+ (let ((ex (parse-comma-separated s (lambda (s)
+ (parse-import s word)))))
+ (if (eq? (peek-token s) ':)
+ (error (string "\":\" in \"" word "\" syntax can only be used "
+ "when importing a single module. "
+ "Split imports into multiple lines."))
+ ex)))))
  (if from
  `(,word (|:| ,first ,@rest))
  (list* word first rest))))

diff --git a/test/parse.jl b/test/parse.jl
@@ -375,3 +375,21 @@ end
  @test :(@foo{bar}[baz]) == :((@foo{bar})[baz])
  @test :(@foo{bar} + baz) == :((@foo{bar}) + baz)
 end
+
+@testset "issue #34650" begin
+ for imprt in [:using, :import]
+ @test Meta.isexpr(Meta.parse("$imprt A, B"), imprt)
+ @test Meta.isexpr(Meta.parse("$imprt A: x, y, z"), imprt)
+
+ err = Expr(
+ :error,
+ "\":\" in \"$imprt\" syntax can only be used when importing a single module. " *
+ "Split imports into multiple lines."
+ )
+ ex = Meta.parse("$imprt A, B: x, y", raise=false)
+ @test ex == err
+
+ ex = Meta.parse("$imprt A: x, B: y", raise=false)
+ @test ex == err
+ end
+end