Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #68

Merged
merged 3 commits into from
Feb 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions samples/petstore/pages.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<resource method="GET">/pets</resource>
<result>
<component type="CardSection" id="petsContainerCardSection">
<data key="id" title="name" description="description" image="imageURL"/>
<assign key="id" title="name" description="description" image="imageURL"/>
<route>/pets/{id}</route>
</component>
</result>
Expand All @@ -33,11 +33,11 @@
<resource method="GET">/pets/{id}</resource>
<result>
<component type="Card" id="petContainerCard">
<data key="id" title="name" description="description" image="imageURL"/>
<assign key="id" title="name" description="description" image="imageURL"/>
<component type="Button" id="petAddToCartButton">
<text>Add to Cart</text>
<save type="localStorage">
<data key="cart"/>
<assign key="cart"/>
</save>
</component>
</component>
Expand All @@ -50,7 +50,7 @@
<resource method="GET">/pets</resource>
<result>
<component type="Table" id="adminPetsContainerTable">
<data key="id"/>
<assign key="id"/>
<component type="Button" id="updatePetButton">
<text>Update</text>
<route>/updatePet/{id}</route>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
@Getter
@Setter
@ToString
public class Data {
public class Assign {
@JacksonXmlProperty(isAttribute = true)
private String key;

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/ravijar/model/xml/Save.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ public class Save {
@JacksonXmlProperty(isAttribute = true)
private String type;

@JacksonXmlProperty(localName = "data")
private Data data;
@JacksonXmlProperty(localName = "assign")
private Assign assign;
}
6 changes: 3 additions & 3 deletions src/main/java/com/ravijar/model/xml/component/Card.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlElementWrapper;
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
import com.ravijar.model.xml.Data;
import com.ravijar.model.xml.Assign;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
Expand All @@ -13,8 +13,8 @@
@Setter
@ToString
public class Card extends Component {
@JacksonXmlProperty(localName = "data")
private Data data;
@JacksonXmlProperty(localName = "assign")
private Assign assign;

@JacksonXmlProperty(localName = "component")
@JacksonXmlElementWrapper(useWrapping = false)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.ravijar.model.xml.component;

import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
import com.ravijar.model.xml.Data;
import com.ravijar.model.xml.Assign;
import com.ravijar.model.xml.Route;
import lombok.Getter;
import lombok.Setter;
Expand All @@ -11,8 +11,8 @@
@Setter
@ToString
public class CardSection extends Component {
@JacksonXmlProperty(localName = "data")
private Data data;
@JacksonXmlProperty(localName = "assign")
private Assign assign;

@JacksonXmlProperty(localName = "route")
private Route route;
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/ravijar/model/xml/component/Table.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlElementWrapper;
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
import com.ravijar.model.xml.Data;
import com.ravijar.model.xml.Assign;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
Expand All @@ -13,8 +13,8 @@
@Setter
@ToString
public class Table extends Component{
@JacksonXmlProperty(localName = "data")
private Data data;
@JacksonXmlProperty(localName = "assign")
private Assign assign;

@JacksonXmlProperty(localName = "component")
@JacksonXmlElementWrapper(useWrapping = false)
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/ravijar/populator/ButtonPopulator.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public void populate(Button source, FreeMarkerButton target) {
if (source.getSave() != null) {
target.setAction("save");
target.setSaveType(source.getSave().getType());
target.setSaveKey(source.getSave().getData().getKey());
target.setSaveKey(source.getSave().getAssign().getKey());
}
}
}
8 changes: 4 additions & 4 deletions src/main/java/com/ravijar/populator/CardPopulator.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ public CardPopulator(OpenAPIParser openAPIParser) {

public void populate(Card source, FreeMarkerCard target) {
populateComponent(source, target);
target.setCardKey(source.getData().getKey());
target.setCardTitle(source.getData().getTitle());
target.setCardDescription(source.getData().getDescription());
target.setCardImage(source.getData().getImage());
target.setCardKey(source.getAssign().getKey());
target.setCardTitle(source.getAssign().getTitle());
target.setCardDescription(source.getAssign().getDescription());
target.setCardImage(source.getAssign().getImage());

List<FreeMarkerComponent> freeMarkerComponents = new ArrayList<>();

Expand Down
8 changes: 4 additions & 4 deletions src/main/java/com/ravijar/populator/CardSectionPopulator.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ public CardSectionPopulator(OpenAPIParser openAPIParser) {

public void populate(CardSection source, FreeMarkerCardSection target) {
populateComponent(source, target);
target.setCardKey(source.getData().getKey());
target.setCardTitle(source.getData().getTitle());
target.setCardDescription(source.getData().getDescription());
target.setCardImage(source.getData().getImage());
target.setCardKey(source.getAssign().getKey());
target.setCardTitle(source.getAssign().getTitle());
target.setCardDescription(source.getAssign().getDescription());
target.setCardImage(source.getAssign().getImage());
target.setRoute(source.getRoute().getUrl());
target.setTemplateLiteralRoute(StringHelper.toTemplateLiteralRoute(source.getRoute().getUrl()));
target.setUrlParameter(StringHelper.extractUrlParameter(source.getRoute().getUrl()));
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/ravijar/populator/TablePopulator.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class TablePopulator extends ComponentPopulator{

public void populate(Table source, FreeMarkerTable target) {
populateComponent(source, target);
target.setRowKey(source.getData().getKey());
target.setRowKey(source.getAssign().getKey());

List<FreeMarkerComponent> freeMarkerComponents = new ArrayList<>();

Expand Down
Loading