Prepare for a breaking change in the Rust compiler. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The soundness fix in rust-lang/rust#115008 will cause schemat to break, even though it is not unsound. The missing bound is very hard to abuse, but still a soundness hole in our type system. It will likely take 12 weeks before a stable compiler with the soundness fix is shipped.
oli-obk
force-pushed
the
breakage_fix
branch
from
5123f52
to
fcdf5a8
Compare
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 11 11
Lines 1864 1864
=======================================
Hits 1817 1817
Misses 47 47
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you for the catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The soundness fix in rust-lang/rust#115008 will cause schemat to break, even though it is not unsound. The missing bound is very hard to abuse, but still a soundness hole in our type system.
It will likely take 12 weeks before a stable compiler with the soundness fix is shipped.