add support for error reporting and logging #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code will need tweaking, but I think it's a good start. I'd be happy to discuss it further before it's committed to the main fork. The biggest thing this new routine needs is an error check so that the log files won't exceed a pre-determined size.
Update from head
Deleted duplicate Star Trek question - one that was better-phrased is in q_39. Reformatted answer with punctuation in q_07
added 2 commits
August 25, 2016 13:58
When this .c program is built, it will put a number at the beginning of each line question file. The result? Each question has a unique number and can be more easily referenced. If this program is used, PLEASE read the comments before running it.
| @@ -359,6 +365,13 @@ def _stop(self, *args): | |||
| self._save_game() | |||
| self.factory.running = False | |||
|
|
|||
| def _write_log(self, logfile, f, q): | |||
There was a problem hiding this comment.
I'm really not a big fan of single letter variables.
I'm guessing 'f' is 'filename' and 'q' is question, but I abhor guessing what variables are supposed to mean and prefer more semantic names for things so there is no room for ambiguity.
|
I should be able to make those changes tomorrow. Would you like me to wait though, @rawsonj ? Sounds like you may want to do some rewriting, or rethinking. |
issue #27 - added show correct answer when someone wins
|
Go ahead. I've been trying to find the time to do a rewrite of this bot for 3 years now. |
|
Closing this pull request. I haven't figured out yet how to separate unrelated commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code will need tweaking, but I think it's a good start. I'd be
happy to discuss it further before it's committed to the main fork. The
biggest thing this new routine needs is an error check so that the log
files won't exceed a pre-determined size.