-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support set html info by app.json #525
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-next #525 +/- ##
=============================================
Coverage 87.80% 87.80%
=============================================
Files 21 21
Lines 779 779
Branches 196 196
=============================================
Hits 684 684
Misses 86 86
Partials 9 9 |
ClarkXia
reviewed
Dec 14, 2020
@@ -10,5 +10,6 @@ | |||
"dependencies": { | |||
"error-stack-parser": "^2.0.6", | |||
"source-map": "^0.7.3" | |||
} | |||
}, | |||
"types": "index.d.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
补充下 files
ClarkXia
approved these changes
Dec 14, 2020
luhc228
approved these changes
Dec 14, 2020
SoloJiang
added a commit
that referenced
this pull request
Dec 14, 2020
* chore: bump rax-app version * chore: remove yarn lock file (#518) * feat: inner config plugin (#524) * refactor: build pha (#516) * feat: support pha * feat: support snapshot * feat: support set html info by app.json (#525) * feat: support set html info by app.json * chore: transform to ts * feat: add type define for error-stack-tracey * chore: rename npmclient * chore: add files field * fix: ci (#528) * chore: bump version (#527) * chore: bump beta version * chore: bump version * chore: bump version * chore: bump app helpers version Co-authored-by: Hengchang Lu <44047106+luhc228@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document/index.jsx
中通过 app.json 配置 title [Enhance] 构建 Web 产物时,app.json 中的 title 配置应该生效 #521