feat: support without document file #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClarkXia
reviewed
Dec 23, 2020
| @@ -180,12 +203,23 @@ async function generateHtml(compilation, options) { | |||
| const files = compilation.entrypoints.get(entryName).getFiles(); | |||
| const assets = getAssetsForPage(files, publicPath); | |||
| const documentContent = compilation.assets[`${tempFile}.js`].source(); | |||
|
|
|||
| let pageSource; | |||
|
|
|||
| try { | |||
| const Document: any = loadDocument(documentContent); | |||
There was a problem hiding this comment.
无 document 场景下，因为存在静态构建，所以依然需要这个逻辑
| @@ -0,0 +1,16 @@ | |||
| export default function getBuiltInHtmlTpl(htmlInfo) { | |||
There was a problem hiding this comment.
嗯，模板部分重复，后续改造计划另开 issue
ClarkXia
approved these changes
Dec 24, 2020
SoloJiang
added a commit
that referenced
this pull request
Dec 24, 2020
* chore: bump version * chore: update version * chore: migrate plugin-ssr (#540) * chore: migrate plugin-ssr * chore: update references * fix: kraken mpa error (#541) * feat: support cloud IDE (#542) * feat: support cloud IDE * chore: typo * chore: change pha get url prefix method * chore: remove useless change * feat(miniapp): supoort set entry when using subpackages (#532) * refactor(miniapp): optimize entry name in runtime miniapp (#544) * feat: support without document file (#546) * feat: support without document file * fix: generate html * feat: ssr * chore: remove useless version * chore: change config (#548) * chore: change config * chore: remove unused code * chore: bump version (#550) * chore: bump version * chore: bump version * chore: update miniapp version Co-authored-by: Hengchang Lu <44047106+luhc228@users.noreply.github.com> Co-authored-by: NK <yxy0919@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.