refactor: ssr html load #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SoloJiang
commented
Feb 4, 2021
SoloJiang
commented
- 新增轻量版 cheerio
- 移除 SSR 运行时对 node 环境的依赖
chenjun1011
reviewed
Feb 4, 2021
| @@ -11,7 +11,7 @@ export default (useRunApp) => { | |||
| const raxServerRenderer = require('rax-app-renderer/lib/server').default; | |||
| const { req, res } = ctx; | |||
| const search = req.search; | |||
| const parsedQuery = qs.parse(search); | |||
| const parsedQuery = parseSearch(search); | |||
There was a problem hiding this comment.
这个方法没有依赖，它的实现就在 loader 里
ClarkXia
reviewed
Feb 4, 2021
| this.root.insertAfter(scripts); | ||
| } | ||
|
|
||
| insertedMetas(): string[] { |
chenjun1011
reviewed
Feb 18, 2021
| @@ -47,7 +47,7 @@ export function insertCommonElements(staticConfig) { | |||
| } | |||
|
|
|||
| export function generateHtmlStructure(htmlStr, htmlInfo?: IHtmlInfo) { | |||
| const $ = cheerio.load(htmlStr); | |||
| const $ = cheerio.load(htmlStr, { decodeEntities: false }); | |||
chenjun1011
reviewed
Feb 18, 2021
| chalk.red('ERR!'), | ||
| chalk.magenta(msg), | ||
| ); | ||
| function parseSearch (search) { |
chenjun1011
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.