Bump php parser to ^4.13.2 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## 2.x #199 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 161 161
===========================================
Files 30 30
Lines 457 457
===========================================
Hits 457 457 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
https://github.com/ray-di/.github/blob/v1/.github/workflows/continuous-integration.yml では current_stable の lowest のケースがないのでサポートが必要かもしれません |
|
@koriym レビューお願いします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以下のように8.2 の lowest dependency のテストにおいて php-parser の deprecate エラーが出ていたので修正されたバージョンの 4.13.2 を利用するように変更しました。
https://github.com/bearsunday/BEAR.Package/actions/runs/3856759902/jobs/6573359007
https://github.com/nikic/PHP-Parser/releases/tag/v4.13.2