Search before asking
Description
The CalculateDesiredResources and CalculateMinResources functions in util.go initialize the resource list slices with an unnecessary empty corev1.ResourceList{}.
We should remove this redundant initializer and use desiredResourcesList := []corev1.ResourceList{} instead.
|
func CalculateDesiredResources(cluster *rayv1.RayCluster) corev1.ResourceList { |
|
desiredResourcesList := []corev1.ResourceList{{}} |
|
headPodResource := CalculatePodResource(cluster.Spec.HeadGroupSpec.Template.Spec) |
|
desiredResourcesList = append(desiredResourcesList, headPodResource) |
|
for _, nodeGroup := range cluster.Spec.WorkerGroupSpecs { |
|
if nodeGroup.Suspend != nil && *nodeGroup.Suspend { |
|
continue |
|
} |
|
podResource := CalculatePodResource(nodeGroup.Template.Spec) |
|
calculateReplicaResource(&podResource, nodeGroup.NumOfHosts) |
|
for i := int32(0); i < *nodeGroup.Replicas; i++ { |
|
desiredResourcesList = append(desiredResourcesList, podResource) |
|
} |
|
} |
|
return sumResourceList(desiredResourcesList) |
|
} |
|
|
|
func CalculateMinResources(cluster *rayv1.RayCluster) corev1.ResourceList { |
|
minResourcesList := []corev1.ResourceList{{}} |
|
headPodResource := CalculatePodResource(cluster.Spec.HeadGroupSpec.Template.Spec) |
|
minResourcesList = append(minResourcesList, headPodResource) |
|
for _, nodeGroup := range cluster.Spec.WorkerGroupSpecs { |
|
podResource := CalculatePodResource(nodeGroup.Template.Spec) |
|
calculateReplicaResource(&podResource, nodeGroup.NumOfHosts) |
|
for i := int32(0); i < *nodeGroup.MinReplicas; i++ { |
|
minResourcesList = append(minResourcesList, podResource) |
|
} |
|
} |
|
return sumResourceList(minResourcesList) |
|
} |
Use case
No response
Related issues
No response
Are you willing to submit a PR?
