Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RayService][Refactor] Remove ctrlResult #2545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RayService][Refactor] Remove ctrlResult #2545

wants to merge 1 commit into from
+15 −16

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Nov 17, 2024 •
edited
Loading

Why are these changes needed?

I am reading the RayService controller source code and found that ctrlResult is not necessary.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421
update
ba71ce5 
Signed-off-by: kaihsun <kaihsun@anyscale.com>
@kevin85421 kevin85421 marked this pull request as ready for review November 17, 2024 04:07
@kevin85421 kevin85421 mentioned this pull request Nov 17, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MortalHappiness MortalHappiness

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin85421 @MortalHappiness