Skip to content

Conversation

@eicherseiji
Copy link
Contributor

@eicherseiji eicherseiji commented Jul 19, 2025

Why are these changes needed?

Related issue number

Resolve #3845.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests, personally conducted by me (screenshots below)
    • This PR is not tested :(
    • GKE collaborator (Yiwen) also tested this image + config combination
Screenshot 2025-07-18 at 5 49 29 PM Screenshot 2025-07-18 at 5 49 21 PM

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
@eicherseiji eicherseiji requested a review from kevin85421 July 19, 2025 01:03
max_model_len: 16384
enable_chunked_prefill: true
enable_prefix_caching: true
trust_remote_code: true
Copy link
Contributor Author

@eicherseiji eicherseiji Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Ray 2.46 image, DeepSeek models do not require trust_remote_code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with our testing on GKE as well

max_model_len: 16384
enable_chunked_prefill: true
enable_prefix_caching: true
trust_remote_code: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with our testing on GKE as well

@andrewsykim andrewsykim merged commit d0b6337 into ray-project:master Jul 19, 2025
25 checks passed
laurafitzgerald pushed a commit to laurafitzgerald/kuberay that referenced this pull request Jul 25, 2025
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
DW-Han pushed a commit to DW-Han/kuberay that referenced this pull request Jul 30, 2025
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
CathalOConnorRH pushed a commit to CathalOConnorRH/kuberay that referenced this pull request Oct 2, 2025
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Change DeepSeek example image to stable release (2.48)

2 participants