Skip to content

Fix: Move replica validation logic to right place. #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kash2104 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Move replica validation logic to right place. #4307

kash2104 wants to merge 2 commits into from

Conversation

@kash2104
Copy link
Contributor

@kash2104 kash2104 commented Dec 23, 2025 •
edited
Loading

Why are these changes needed?

These changes are done to check the validation logic before rayCluster pod creation. It moves the replica validation logic as well as removes the redundant tests. Along with this, unit test are added since we moved the logic from utils.go to validation.go.

Related issue number

Closes #4101

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kash2104 kash2104 force-pushed the issue-4101 branch 3 times, most recently from d1d7b57 to eb654d7 Compare December 24, 2025 06:09
@JiangJiaWei1103
Copy link
Contributor

JiangJiaWei1103 commented Dec 24, 2025

Thanks for your effort.

cc @Future-Outlier
This PR duplicates with #4116, which seemed inactive now. Should we close #4116 and work on this one?

@kash2104
Copy link
Contributor Author

kash2104 commented Dec 24, 2025 •
edited
Loading

I have gone through #4116 but it was inactive and no changes were being made after the merging of volcano pr. Many changes are required since volcano pr's merging, that's why I opened up this PR.

@JiangJiaWei1103
Copy link
Contributor

JiangJiaWei1103 commented Dec 24, 2025

Gotcha. Let's wait for maintainers' reply. I'll help review, thank you.

@JiangJiaWei1103 JiangJiaWei1103 moved this to Backlog in My Kuberay & Ray Dec 24, 2025
@kash2104
Copy link
Contributor Author

kash2104 commented Jan 1, 2026 •
edited
Loading

@Future-Outlier Just wanted to follow up - do you prefer closing #4116 and continuing the work in this PR?

@Future-Outlier
Copy link
Member

Future-Outlier commented Jan 1, 2026

@Future-Outlier Just wanted to follow up - do you prefer closing #4116 and continuing the work in this PR?

Hi, @kash2104 I just left a comment to #4116 and ask her if she have time to finish the work.
if after 2 weeks she haven't replied, you can take over it

@kash2104
Fix: Replica validation logic in right place.
2a1f87f 
1. Remove validation logic from GetWorkerGroupDesiredReplicas (utils.go)
and add this logic to ValidateRayClusterSpec (validation.go).
2. Remove unnecessary tests from TestGetWorkerGroupDesiredReplicas.
3. Remove the unused ctx.
@kash2104 kash2104 force-pushed the issue-4101 branch 2 times, most recently from 0ad38fc to 529b021 Compare January 1, 2026 16:54
@kash2104
Test: Add unit test for replica validation.
bc5decd 
This is added since we moved the validation logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin85421 kevin85421 Awaiting requested review from kevin85421 kevin85421 is a code owner

@andrewsykim andrewsykim Awaiting requested review from andrewsykim andrewsykim is a code owner

@rueian rueian Awaiting requested review from rueian rueian is a code owner

@MortalHappiness MortalHappiness Awaiting requested review from MortalHappiness MortalHappiness is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move Replica validation to validation.go

3 participants

@kash2104 @JiangJiaWei1103 @Future-Outlier