Skip to content

Commit

Permalink
[wheel] cut "cpp" out of "all" (#46886)
Browse files Browse the repository at this point in the history
all will not include "cpp" anymore; use "allcpp" instead if "cpp" is
required. "all" will just be "all python".

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
  • Loading branch information
aslonnie authored Aug 2, 2024
1 parent f9eb902 commit 1df0c8e
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def get_packages(self):
],
"default": [
# If adding dependencies necessary to launch the dashboard api server,
# please add it to dashboard/optional_deps.py as well.
# please add it to python/ray/dashboard/optional_deps.py as well.
"aiohttp >= 3.7,<3.10.0",
"aiohttp_cors",
"colorful",
Expand Down Expand Up @@ -316,9 +316,19 @@ def get_packages(self):
)
)

# "all" will not include "cpp" anymore. It is a big depedendency
# that most people do not need.
#
# Instead, when cpp is supported, we add a "all-cpp".
setup_spec.extras["all"] = list(
set(chain.from_iterable(setup_spec.extras.values()))
set(
chain.from_iterable([v for k, v in setup_spec.extras.items() if k != "cpp"])
)
)
if RAY_EXTRA_CPP:
setup_spec.extras["all-cpp"] = list(
set(setup_spec.extras["all"] + setup_spec.extras["cpp"])
)

# These are the main dependencies for users of ray. This list
# should be carefully curated. If you change it, please reflect
Expand Down

0 comments on commit 1df0c8e

Please sign in to comment.