Skip to content

Commit

Permalink
[serve] Remove print statement + fix lint (#35439)
Browse files Browse the repository at this point in the history
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
  • Loading branch information
zcin committed May 17, 2023
1 parent a985df5 commit 5b3e64f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion python/ray/serve/_private/http_state.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ def update(self):
if finished:
try:
ray.get(finished[0])
print("got object ref!")
self.set_status(HTTPProxyStatus.HEALTHY)
except Exception as e:
logger.warning(
Expand Down
6 changes: 3 additions & 3 deletions python/ray/serve/tests/test_http_state.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import pytest

import ray
from ray.experimental.state.api import list_actors
from ray._private.test_utils import SignalActor, wait_for_condition
from ray.serve.config import DeploymentMode, HTTPOptions
from ray.serve._private.common import HTTPProxyStatus
Expand Down Expand Up @@ -134,7 +135,6 @@ def check_proxy(status):


def test_http_proxy_shutdown():
from ray.experimental.state.api import list_actors
ray.init()

@ray.remote(num_cpus=0)
Expand Down Expand Up @@ -163,11 +163,11 @@ def check_proxy(status):
# Shutdown the http proxy state. Wait for the http proxy actor to be killed
state.shutdown()
wait_for_condition(lambda: len(list_actors(filters=[("state", "=", "ALIVE")])) == 0)

# Make sure that the state doesn't try to check on the status of the dead actor
state.update()
assert state.status == HTTPProxyStatus.HEALTHY

ray.shutdown()


Expand Down

0 comments on commit 5b3e64f

Please sign in to comment.