Skip to content

Commit

Permalink
[release] update if xgboost test suite requires result or not. (#32340)
Browse files Browse the repository at this point in the history
* [release] update if xgboost test suite require result or not.

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>

* format

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>

* Revert "format"

This reverts commit 3140401.

* Revert "[release] update if xgboost test suite require result or not."

This reverts commit 03ca1c0.

* change to default alert.

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>

* remove tests from xgboost_tests alerts.

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>

---------

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
  • Loading branch information
xwjiang2010 authored Feb 9, 2023
1 parent 63d922b commit 5c1c888
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
7 changes: 1 addition & 6 deletions release/ray_release/alerts/xgboost_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,7 @@ def handle_result(
time_taken = result.results.get("time_taken", float("inf"))
num_terminated = result.results.get("trial_states", {}).get("TERMINATED", 0)

if test_name in ["distributed_api_test", "ft_small_elastic", "ft_small_nonelastic"]:
if not result.status == "finished":
return f"Test script did not finish successfully ({result.status})."

return None
elif test_name.startswith("tune_"):
if test_name.startswith("tune_"):
msg = ""
if test_name == "tune_small":
target_terminated = 4
Expand Down
6 changes: 3 additions & 3 deletions release/release_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,7 @@
type: job


alert: xgboost_tests
alert: default

- name: xgboost_ft_small_elastic
group: XGBoost
Expand All @@ -751,7 +751,7 @@
type: job


alert: xgboost_tests
alert: default

- name: xgboost_ft_small_non_elastic
group: XGBoost
Expand All @@ -778,7 +778,7 @@
type: job


alert: xgboost_tests
alert: default

- name: xgboost_tune_small
group: XGBoost
Expand Down

0 comments on commit 5c1c888

Please sign in to comment.