[tune] remove legacy client API (#41469)

doc/source/tune/api/api.rst

@@ -27,5 +27,4 @@ on `Github`_.
     env.rst
     integration.rst
     internals.rst
-    client.rst
     cli.rst

python/ray/tune/BUILD

@@ -375,14 +375,6 @@ py_test(
     tags = ["team:ml", "exclusive"],
 )
 
-py_test(
-    name = "test_tune_server",
-    size = "medium",
-    srcs = ["tests/test_tune_server.py"],
-    deps = [":tune_lib"],
-    tags = ["team:ml", "exclusive"],
-)
-
 py_test(
     name = "test_tuner",
     size = "large",

python/ray/tune/execution/tune_controller.py

@@ -61,7 +61,6 @@
 from ray.tune.utils.log import Verbosity, has_verbosity
 from ray.tune.execution.placement_groups import PlacementGroupFactory
 from ray.tune.utils.serialization import TuneFunctionDecoder, TuneFunctionEncoder
-from ray.tune.web_server import TuneServer
 from ray.util.annotations import DeveloperAPI, Deprecated
 from ray.util.debug import log_once
 
@@ -82,7 +81,6 @@ def __init__(
         scheduler: Optional[TrialScheduler] = None,
         stopper: Optional[Stopper] = None,
         resume: Union[str, bool] = False,
-        server_port: Optional[int] = None,
         fail_fast: bool = False,
         checkpoint_period: Union[str, int] = None,
         callbacks: Optional[List[Callback]] = None,
@@ -205,11 +203,6 @@ def __init__(
             int(os.environ.get("TUNE_PRINT_ALL_TRIAL_ERRORS", "1"))
         )
 
-        self._server = None
-        self._server_port = server_port
-        if server_port is not None:
-            self._server = TuneServer(self, self._server_port)
-
         self._trials: List[Trial] = []
         self._live_trials: Set[Trial] = set()  # Set of non-terminated trials
         self._cached_trial_decisions = {}
@@ -752,13 +745,6 @@ def step(self):
 
         self._iteration += 1
 
-        if self._server:
-            with warn_if_slow("server"):
-                self._process_stop_requests()
-
-            if self.is_finished():
-                self._server.shutdown()
-
         with warn_if_slow("on_step_end"):
             self.on_step_end()
         with warn_if_slow("callbacks.on_step_end"):
@@ -2040,7 +2026,6 @@ def __getstate__(self):
             "_trials",
             "_live_trials",
             "_stop_queue",
-            "_server",
             "_search_alg",
             "_placeholder_resolvers",
             "_scheduler_alg",
@@ -2070,12 +2055,9 @@ def __getstate__(self):
             "_actor_cache",
         ]:
             del state[k]
-        state["launch_web_server"] = bool(self._server)
         return state
 
     def __setstate__(self, state):
-        launch_web_server = state.pop("launch_web_server")
-
         # Use session_str from previous checkpoint if does not exist
         session_str = state.pop("_session_str")
         self.__dict__.setdefault("_session_str", session_str)
@@ -2086,9 +2068,6 @@ def __setstate__(self, state):
         self.__dict__.update(state)
         self._checkpoint_manager = self._create_checkpoint_manager()
 
-        if launch_web_server:
-            self._server = TuneServer(self, self._server_port)
-
 
 class _TrialExecutorWrapper:
     """Wraps around TrialExecutor class, intercepts API calls and warns users

python/ray/tune/tests/test_tune_save_restore.py

@@ -10,7 +10,6 @@
 import ray
 from ray import tune
 from ray.train import CheckpointConfig
-from ray.rllib import _register_all
 from ray.tune import Trainable
 from ray.tune.utils import validate_save_restore
 
@@ -52,8 +51,6 @@ def tearDown(self):
             shutil.rmtree(self.absolute_local_dir, ignore_errors=True)
             self.absolute_local_dir = None
         ray.shutdown()
-        # Without this line, test_tune_server.testAddTrial would fail.
-        _register_all()
 
     def _get_trial_dir(self, absoulte_exp_dir):
         print("looking for", self.MockTrainable._name)