Skip to content

Commit f0c7b53

Browse files
authored
[deps][ci] compiling all depsets in single job (#57957)
combining all depset checks into a single job TODO: add raydepset feature to build all depsets for the depset graph --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
1 parent 4ba962c commit f0c7b53

File tree

3 files changed

+5
-22
lines changed

3 files changed

+5
-22
lines changed

.buildkite/dependencies.rayci.yml

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -19,31 +19,14 @@ steps:
1919
job_env: oss-ci-base_test-py3.11
2020
depends_on: oss-ci-base_test-multipy
2121

22-
- label: ":tapioca: build: raydepsets: compile LLM dependencies"
23-
key: raydepsets_compile_llm_dependencies
22+
- label: ":tapioca: build: raydepsets: compile all dependencies"
23+
key: raydepsets_compile_all_dependencies
2424
tags: always
2525
instance_type: small
2626
commands:
27+
# TODO: add raydepsets build all command
2728
- bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/rayllm.depsets.yaml --check
28-
- chown -R 2000:100 /artifact-mount
29-
- cp ./python/deplocks/llm/* /artifact-mount/
30-
job_env: manylinux
31-
depends_on: manylinux
32-
33-
- label: ":tapioca: build: raydepsets: compile ray img dependencies"
34-
key: raydepsets_compile_rayimg_dependencies
35-
tags: always
36-
instance_type: medium
37-
commands:
3829
- bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/rayimg.depsets.yaml --check
39-
job_env: manylinux
40-
depends_on: manylinux
41-
42-
- label: ":tapioca: build: raydepsets: compile multimodal inference release test dependencies"
43-
key: raydepsets_compile_multimodal_inference_release_test_dependencies
44-
tags: always
45-
instance_type: medium
46-
commands:
4730
- bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/release_multimodal_inference_benchmarks_tests.depsets.yaml --check
4831
job_env: manylinux
4932
depends_on: manylinux

ci/raydepsets/cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def diff_lock_files(self):
139139
diffs = self.get_diffs()
140140
if len(diffs) > 0:
141141
raise RuntimeError(
142-
"Lock files are not up to date. Please update lock files and push the changes.\n"
142+
f"Lock files are not up to date for config: {self.config_name}. Please update lock files and push the changes.\n"
143143
+ "".join(diffs)
144144
)
145145
click.echo("Lock files are up to date.")

ci/raydepsets/tests/test_cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ def test_diff_lock_files_out_of_date(self):
655655
with self.assertRaises(RuntimeError) as e:
656656
manager.diff_lock_files()
657657
assert (
658-
"Lock files are not up to date. Please update lock files and push the changes."
658+
"Lock files are not up to date for config: test.depsets.yaml. Please update lock files and push the changes."
659659
in str(e.exception)
660660
)
661661
assert "+emoji==2.8.0" in str(e.exception)

0 commit comments

Comments
 (0)