[deps][ci] compiling all depsets in single job #57957
Merged
+5
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
aslonnie
approved these changes
Oct 21, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request combines multiple depset checks into a single job in the .buildkite/dependencies.rayci.yml file. This change aims to consolidate the dependency compilation process for raydepsets, improving efficiency and reducing redundancy in the CI pipeline. The review focuses on ensuring the correctness of the combined job and identifying any potential issues arising from the consolidation.
Comment on lines
26
to
29
| commands: | ||
| - bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/rayllm.depsets.yaml --check | ||
| - chown -R 2000:100 /artifact-mount | ||
| - cp ./python/deplocks/llm/* /artifact-mount/ | ||
| job_env: manylinux | ||
| depends_on: manylinux | ||
|
|
||
| - label: ":tapioca: build: raydepsets: compile ray img dependencies" | ||
| key: raydepsets_compile_rayimg_dependencies | ||
| tags: always | ||
| instance_type: medium | ||
| commands: | ||
| - bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/rayimg.depsets.yaml --check | ||
| job_env: manylinux | ||
| depends_on: manylinux | ||
|
|
||
| - label: ":tapioca: build: raydepsets: compile multimodal inference release test dependencies" | ||
| key: raydepsets_compile_multimodal_inference_release_test_dependencies | ||
| tags: always | ||
| instance_type: medium | ||
| commands: | ||
| - bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/release_multimodal_inference_benchmarks_tests.depsets.yaml --check |
Contributor
There was a problem hiding this comment.
Consider consolidating these bazel run commands into a single command for better readability and maintainability. This can be achieved by chaining the commands with &&.
commands:
- bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/rayllm.depsets.yaml --check && \
bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/rayimg.depsets.yaml --check && \
bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/release_multimodal_inference_benchmarks_tests.depsets.yaml --check
aslonnie
reviewed
Oct 21, 2025
| - label: ":tapioca: build: raydepsets: compile LLM dependencies" | ||
| key: raydepsets_compile_llm_dependencies | ||
| - label: ":tapioca: build: raydepsets: compile all dependencies" | ||
| key: raydepsets_compile_all_dependencies |
Collaborator
There was a problem hiding this comment.
maybe add the TODO line in the code here?
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
aslonnie
approved these changes
Oct 23, 2025
aslonnie
deleted the
elliot-barn/group-dependency-checks-in-single-job
branch
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 27, 2025
combining all depset checks into a single job TODO: add raydepset feature to build all depsets for the depset graph --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: xgui <xgui@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
combining all depset checks into a single job TODO: add raydepset feature to build all depsets for the depset graph --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
combining all depset checks into a single job TODO: add raydepset feature to build all depsets for the depset graph --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combining all depset checks into a single job
TODO: add raydepset feature to build all depsets for the depset graph