Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] Remove pin from opentelemetry packages #32051

Closed
pcmoritz opened this issue Jan 30, 2023 · 1 comment · Fixed by #32120
Closed

[Observability] Remove pin from opentelemetry packages #32051

pcmoritz opened this issue Jan 30, 2023 · 1 comment · Fixed by #32120
Assignees
@rkooo567
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core release-blocker P0 Issue that blocks the release

Comments

@pcmoritz
Copy link
Contributor

What happened + What you expected to happen

Right now, the opentelemetry packages are pinned here:

https://github.com/ray-project/ray/blob/master/python/setup.py#L251

We should remove the pins and upgrade the packages in our CI

Versions / Dependencies

Ray 2.2 and master

Reproduction script

None

Issue Severity

High: It blocks me from completing my task.
@pcmoritz pcmoritz added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jan 30, 2023
@rkooo567 rkooo567 added release-blocker P0 Issue that blocks the release core Issues that should be addressed in Ray Core and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jan 30, 2023
@rkooo567 rkooo567 mentioned this issue Jan 31, 2023
Merged
7 tasks
@rkooo567
Copy link
Contributor

Status: Have a PR out ^

rkooo567 added a commit that referenced this issue Feb 1, 2023
@rkooo567
[Observability] Unpin open telemetry version for tracing feature (#32120
5dd1406 
)

Signed-off-by: SangBin Cho <rkooo567@gmail.com>

<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->

## Why are these changes needed?

This PR unpins the version of open telemetry as it is too strict for an experimental tracing feature.  

## Related issue number

Closes #32051

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
- [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(
edoakes pushed a commit to edoakes/ray that referenced this issue Mar 22, 2023
@rkooo567 @edoakes
[Observability] Unpin open telemetry version for tracing feature (ray…
3088a25 
…-project#32120)

Signed-off-by: SangBin Cho <rkooo567@gmail.com>

<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->

## Why are these changes needed?

This PR unpins the version of open telemetry as it is too strict for an experimental tracing feature.

## Related issue number

Closes ray-project#32051

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
- [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkooo567 rkooo567

Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Observability] Unpin open telemetry version for tracing feature rkooo567/ray
2 participants
@pcmoritz @rkooo567