Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasets] Validate sort key in logical operator #32137

Closed
c21 opened this issue Jan 31, 2023 · 0 comments · Fixed by #34282
Closed

[Datasets] Validate sort key in logical operator #32137

c21 opened this issue Jan 31, 2023 · 0 comments · Fixed by #34282
Assignees
@scottjlee
Labels
data Ray Data-related issues P1 Issue that should be fixed within a few weeks
Milestone
Dataset Execution...

Comments

@c21
Copy link
Contributor

c21 commented Jan 31, 2023

Description

As a followup of #32133, we should validate key with block.py:_validate_key_fn(), in generate_sort_fn() before doing sort.

Use case

No response
@c21 c21 added P1 Issue that should be fixed within a few weeks data Ray Data-related issues labels Jan 31, 2023
@c21 c21 mentioned this issue Jan 31, 2023
Merged
7 tasks
@c21 c21 added this to the Dataset Execution Optimizer milestone Feb 15, 2023
@c21 c21 added P0 Issues that should be fixed in short order P1 Issue that should be fixed within a few weeks and removed P1 Issue that should be fixed within a few weeks P0 Issues that should be fixed in short order labels Feb 16, 2023
@scottjlee scottjlee mentioned this issue Apr 11, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottjlee scottjlee

Labels
data Ray Data-related issues P1 Issue that should be fixed within a few weeks
Projects
None yet
Milestone
Dataset Execution Optimizer
Development

Successfully merging a pull request may close this issue.

[Dataset] Validate sort key in Sort LogicalOperator scottjlee/ray
2 participants
@c21 @scottjlee