[Datasets] Add logical operator for sort() #32133
Merged
+268
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c21
requested review from
ericl,
scv119,
clarkzinzow,
jjyao and
jianoaix
as code owners
c21
commented
Jan 31, 2023
|
|
||
|
|
||
| class SortTaskSpec(ExchangeTaskSpec): | ||
| """ |
There was a problem hiding this comment.
This file is copied from https://github.com/ray-project/ray/blob/master/python/ray/data/_internal/sort.py, with change from BlockList to RefBundle.
Signed-off-by: Cheng Su <scnju13@gmail.com>
c21
commented
Jan 31, 2023
| descending: bool, | ||
| ) -> AllToAllTransformFn: | ||
| """Generate function to sort blocks by the specified key column or key function.""" | ||
| # TODO: validate key with block._validate_key_fn. |
There was a problem hiding this comment.
Created #32137 for followup. This needs more refactoring, as it involves Dataset object.
ericl
approved these changes
Feb 1, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
This PR is to add logical operator for `sort()`, the change includes: * `Sort` logical operator * `SortTaskSpec` to copy from `sort.py` * `generate_sort_fn` is generated function for sort Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
c21
pushed a commit
that referenced
this pull request
Apr 14, 2023
As a followup of #32133, we should validate key with block.py:_validate_key_fn(), in generate_sort_fn() before doing sort. Signed-off-by: Scott Lee <sjl@anyscale.com>
vitsai
pushed a commit
to vitsai/ray
that referenced
this pull request
Apr 17, 2023
) As a followup of ray-project#32133, we should validate key with block.py:_validate_key_fn(), in generate_sort_fn() before doing sort. Signed-off-by: Scott Lee <sjl@anyscale.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
) As a followup of ray-project#32133, we should validate key with block.py:_validate_key_fn(), in generate_sort_fn() before doing sort. Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
) As a followup of ray-project#32133, we should validate key with block.py:_validate_key_fn(), in generate_sort_fn() before doing sort. Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cheng Su scnju13@gmail.com
Why are these changes needed?
This PR is to add logical operator for
sort(), the change includes:Sortlogical operatorSortTaskSpecto copy fromsort.pygenerate_sort_fnis generated function for sortRelated issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.