Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] regressions in ray start --head usage in OSX #32640

Closed
rkooo567 opened this issue Feb 16, 2023 · 0 comments · Fixed by #32646
Closed

[Core] regressions in ray start --head usage in OSX #32640

rkooo567 opened this issue Feb 16, 2023 · 0 comments · Fixed by #32646
Assignees
@stephanie-wang
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core P0 Issues that should be fixed in short order

Comments

@rkooo567
Copy link
Contributor

What happened + What you expected to happen

Two issues

  1. When ray start --head is used from Mac, ray.init() doesn't work anymore. It just hangs forever. I think it should just work, and we should only disallow connecting worker nodes (i.e., ray start --address localhost:head_node_port).
  2. When we use the env var + ray start --head, there's the incoming request approval which we didn't have it before @jjyao fixed it long time ago).

Versions / Dependencies

master

Reproduction script

ray start --head in MacOSX

Issue Severity

None
@rkooo567 rkooo567 added bug Something that is supposed to be working; but isn't P0 Issues that should be fixed in short order core Issues that should be addressed in Ray Core labels Feb 16, 2023
@stephanie-wang stephanie-wang mentioned this issue Feb 17, 2023
Merged
rkooo567 pushed a commit that referenced this issue Feb 21, 2023
@stephanie-wang
[core] Fix error for connecting to existing cluster from OSX/Windows …
7774cc3 
…driver (#32646)

Removes an unnecessary check when connecting to the cluster. See #32640.
edoakes pushed a commit to edoakes/ray that referenced this issue Mar 22, 2023
@stephanie-wang @edoakes
[core] Fix error for connecting to existing cluster from OSX/Windows …
6ab5442 
…driver (ray-project#32646)

Removes an unnecessary check when connecting to the cluster. See ray-project#32640.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this issue Mar 22, 2023
@stephanie-wang @peytondmurray
[core] Fix error for connecting to existing cluster from OSX/Windows …
8cd0757 
…driver (ray-project#32646)

Removes an unnecessary check when connecting to the cluster. See ray-project#32640.
elliottower pushed a commit to elliottower/ray that referenced this issue Apr 22, 2023
@stephanie-wang @elliottower
[core] Fix error for connecting to existing cluster from OSX/Windows …
e115c7e 
…driver (ray-project#32646)

Removes an unnecessary check when connecting to the cluster. See ray-project#32640.

Signed-off-by: elliottower <elliot@elliottower.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanie-wang stephanie-wang

Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core P0 Issues that should be fixed in short order
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Fix error for connecting to existing cluster from OSX/Windows driver stephanie-wang/ray
2 participants
@stephanie-wang @rkooo567