Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]Mac OS Pipeline not kicked off #32774

Closed
ArturNiederfahrenhorst opened this issue Feb 23, 2023 · 4 comments
Closed

[CI]Mac OS Pipeline not kicked off #32774

ArturNiederfahrenhorst opened this issue Feb 23, 2023 · 4 comments
Assignees
Labels
bug Something that is supposed to be working; but isn't P0 Issues that should be fixed in short order

Comments

@ArturNiederfahrenhorst
Copy link
Contributor

What happened + What you expected to happen

Why are these changes needed?

I bisected our buildkite history from master (where this kickoff always happens) and found the following:

First time the pipeline did not get kicked off properly:
Screenshot 2023-02-23 at 06 59 32

Last time the pipeline got kicked off properly:
Screenshot 2023-02-23 at 06 59 55

The pipeline has been broken since Feb 14th, very close to #32409.
I don't have enough context on the changes in the PR in question to confirm that it causes this issue so this is sort of a shot in the dark.

Versions / Dependencies

master

Reproduction script

Open PR to master, have a look at buildkite to see that Mac OS tests don't run.

Issue Severity

None

@ArturNiederfahrenhorst ArturNiederfahrenhorst added bug Something that is supposed to be working; but isn't P0 Issues that should be fixed in short order labels Feb 23, 2023
@stephanie-wang
Copy link
Contributor

Hmm it seems like it stopped working before that PR, though?

Should we try reverting it and see if it passes in CI?

@ArturNiederfahrenhorst
Copy link
Contributor Author

@rkooo567 said that this was fixed by 7774cc3, I don't see the jobs running on CI for master right now though.

The buildkite job for the PR in question still ran fine: https://buildkite.com/ray-project/oss-ci-build-pr/builds/12043#_

@ArturNiederfahrenhorst
Copy link
Contributor Author

The first PR where they did not run is d092b12

@scv119
Copy link
Contributor

scv119 commented Mar 1, 2023

Looks the problem is fixed by @krfricke

@scv119 scv119 closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't P0 Issues that should be fixed in short order
Projects
None yet
Development

No branches or pull requests

5 participants