[core] Add opt-in flag for Windows and OSX clusters, update ray start output to match docs #32409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clusters Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
…nto windows-osx-support
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
stephanie-wang
requested review from
architkulkarni,
wuisawesome,
DmitriGekhtman,
maxpumperla,
pcmoritz and
a team
as code owners
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu>
jjyao
approved these changes
Feb 13, 2023
stephanie-wang
added
the
tests-ok
ericl
approved these changes
Feb 14, 2023
This was referenced Feb 23, 2023
ArturNiederfahrenhorst
added a commit
to ArturNiederfahrenhorst/ray
that referenced
this pull request
Feb 24, 2023
…ay start output to match docs (ray-project#32409)" This reverts commit bf5e721.
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
… output to match docs (ray-project#32409) Un-revert ray-project#31166. This PR cleans up a few usability issues around Ray clusters: - Makes some cleanups to the ray start log output to match the new documentation on Ray clusters. Mainly, de-emphasize Ray Client and recommend jobs instead. - Add an opt-in flag for enabling multi-node clusters for OSX and Windows. Previously, it was possible to start a multi-node cluster, but then any Ray programs would fail mysteriously after connecting to the cluster. Now, it will warn the user with an error message if the opt-in flag is not set. - Document multi-node support for OSX and Windows. Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu> Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
8 tasks
jjyao
added a commit
that referenced
this pull request
Apr 11, 2023
With #32409, we stopped printing out information like dashboard url when creating a single node ray cluster on OSX and windows. This is a regression and this PR reverts back to the old behavior. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
jjyao
added a commit
that referenced
this pull request
Apr 11, 2023
With #32409, we stopped printing out information like dashboard url when creating a single node ray cluster on OSX and windows. This is a regression and this PR reverts back to the old behavior. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
8 tasks
jjyao
added a commit
that referenced
this pull request
Apr 11, 2023
With #32409, we stopped printing out information like dashboard url when creating a single node ray cluster on OSX and windows. This is a regression and this PR reverts back to the old behavior. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
… output to match docs (ray-project#32409) Un-revert ray-project#31166. This PR cleans up a few usability issues around Ray clusters: - Makes some cleanups to the ray start log output to match the new documentation on Ray clusters. Mainly, de-emphasize Ray Client and recommend jobs instead. - Add an opt-in flag for enabling multi-node clusters for OSX and Windows. Previously, it was possible to start a multi-node cluster, but then any Ray programs would fail mysteriously after connecting to the cluster. Now, it will warn the user with an error message if the opt-in flag is not set. - Document multi-node support for OSX and Windows. Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu> Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> Signed-off-by: elliottower <elliot@elliottower.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
With ray-project#32409, we stopped printing out information like dashboard url when creating a single node ray cluster on OSX and windows. This is a regression and this PR reverts back to the old behavior. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
With ray-project#32409, we stopped printing out information like dashboard url when creating a single node ray cluster on OSX and windows. This is a regression and this PR reverts back to the old behavior. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Un-revert #31166.
This PR cleans up a few usability issues around Ray clusters: