Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Dataset operator names are confusing when operator ends with a number #48482

Closed
alanwguo opened this issue Oct 31, 2024 · 1 comment · Fixed by #48805
Closed

[Data] Dataset operator names are confusing when operator ends with a number #48482

alanwguo opened this issue Oct 31, 2024 · 1 comment · Fixed by #48805
Assignees
Labels
bug Something that is supposed to be working; but isn't good first issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@alanwguo
Copy link
Contributor

What happened + What you expected to happen

Screenshot 2024-10-31 at 4 44 43 PM

Notice that the operator names end with an integer that represents the order of the operator.

When the operator name also has an integer at the end like limit=5, the order gets appended afterwards and it looks like limit=56 which is very confusing.

Versions / Dependencies

2.37.0

Reproduction script

import ray
import time

def f(x):
    time.sleep(0.1)
    return x

def g(x):
    time.sleep(1)
    return x

ray.data.range(100).map(f).map(g, num_cpus=0.1).take_batch(5)

Issue Severity

Medium: It is a significant difficulty but I can work around it.

@alanwguo alanwguo added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) good first issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling labels Oct 31, 2024
@gitlijian
Copy link

gitlijian commented Nov 3, 2024

Hello Alanwguo, can I participate in resolving this issue? For example, in the situation you mentioned, can we check in advance whether the character 'limit=5' ends with a number between limit=5 and limit=56? If it ends with a number, we can add a '_' and 'limit=5->limit=5_6'. @alanwguo

@can-anyscale can-anyscale self-assigned this Nov 19, 2024
can-anyscale added a commit that referenced this issue Nov 22, 2024
In #48482, a user reported that
the name used in ray data dashboard is confusing, in case the name of
the operator ends with a number.

The name used in ray data dashboard is actually just a key identifier of
the dataset and not its name. I add another field to encode its name and
use it for data dashboard.

Closes #48482

Test:
- CI
- More beautiful than ever

<img width="1443" alt="Screenshot 2024-11-21 at 12 17 21 PM"
src="https://github.com/user-attachments/assets/4037fb49-e03c-4c4e-9f33-33f181b58808">

Signed-off-by: can <can@anyscale.com>
jecsand838 pushed a commit to jecsand838/ray that referenced this issue Dec 4, 2024
)

In ray-project#48482, a user reported that
the name used in ray data dashboard is confusing, in case the name of
the operator ends with a number.

The name used in ray data dashboard is actually just a key identifier of
the dataset and not its name. I add another field to encode its name and
use it for data dashboard.

Closes ray-project#48482

Test:
- CI
- More beautiful than ever

<img width="1443" alt="Screenshot 2024-11-21 at 12 17 21 PM"
src="https://github.com/user-attachments/assets/4037fb49-e03c-4c4e-9f33-33f181b58808">

Signed-off-by: can <can@anyscale.com>
Signed-off-by: Connor Sanders <connor@elastiflow.com>
dentiny pushed a commit to dentiny/ray that referenced this issue Dec 7, 2024
)

In ray-project#48482, a user reported that
the name used in ray data dashboard is confusing, in case the name of
the operator ends with a number.

The name used in ray data dashboard is actually just a key identifier of
the dataset and not its name. I add another field to encode its name and
use it for data dashboard.

Closes ray-project#48482

Test:
- CI
- More beautiful than ever

<img width="1443" alt="Screenshot 2024-11-21 at 12 17 21 PM"
src="https://github.com/user-attachments/assets/4037fb49-e03c-4c4e-9f33-33f181b58808">

Signed-off-by: can <can@anyscale.com>
Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't good first issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants