Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Replace flake8, isort, black with ruff #48508

Open
Tracked by #47991
MortalHappiness opened this issue Nov 2, 2024 · 2 comments
Open
Tracked by #47991

[CI] Replace flake8, isort, black with ruff #48508

MortalHappiness opened this issue Nov 2, 2024 · 2 comments
Assignees
Labels

Comments

@MortalHappiness
Copy link
Member

MortalHappiness commented Nov 2, 2024

In #47991 (comment)

Since ruff is drop-in replacement for flake8 so upgrading flake8 and switching to ruff should require the similar amount of efforts.

@MortalHappiness MortalHappiness self-assigned this Nov 2, 2024
@MortalHappiness MortalHappiness changed the title Replace flake8, isort, black with ruff [CI] Replace flake8, isort, black with ruff Nov 2, 2024
@win5923
Copy link
Contributor

win5923 commented Nov 21, 2024

Hi @MortalHappiness, can you provide some guidance on how to replace flake8, isort, and black with ruff? Apart from updating the .pre-commit-config.yaml to use ruff, what else needs to be done?

@MortalHappiness
Copy link
Member Author

Hi @win5923 Actually, I don't know either. You can check the codebase to see what needs to be changed, and if you have any questions, feel free to ping me, and I can ask others for you.

cc @aslonnie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants