Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Replace flake8, isort, black with ruff #48848

Closed
wants to merge 1 commit into from

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Nov 21, 2024

Why are these changes needed?

  • Remove E123, E126, E704, W503, W504, and B001, as these rules are not included in Ruff.
  • The remaining configurations follow the .flake8 and .isort.cfg files.

Ref: #48508

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@win5923 win5923 marked this pull request as draft November 21, 2024 16:50
@win5923
Copy link
Contributor Author

win5923 commented Nov 22, 2024

@win5923 win5923 marked this pull request as ready for review November 23, 2024 17:24
@win5923 win5923 marked this pull request as draft November 23, 2024 17:35
Signed-off-by: win5923 <ken89@kimo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant