Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][release] Need to update azure-cli-core version to update paramiko #48733

Open
rynewang opened this issue Nov 13, 2024 · 0 comments · May be fixed by #48847
Open

[core][release] Need to update azure-cli-core version to update paramiko #48733

rynewang opened this issue Nov 13, 2024 · 0 comments · May be fixed by #48847
Assignees
@MortalHappiness
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks

Comments

@rynewang
Copy link
Contributor

What happened + What you expected to happen

Now we depend on paramiko==2.12.0 which comes from azure-cli-core==2.62.0 from a test-requirements.txt, and we are not directly using it any way.

This paramiko version is now considered old and prints some encryption security warnings. we should consider upgrading azure-cli-core to stop it.

Versions / Dependencies

master

Reproduction script

Issue Severity

Medium: It is a significant difficulty but I can work around it.
@rynewang rynewang added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 13, 2024
@rynewang rynewang added P0 Issues that should be fixed in short order core Issues that should be addressed in Ray Core and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 14, 2024
@jjyao jjyao added P1 Issue that should be fixed within a few weeks and removed P0 Issues that should be fixed in short order labels Nov 14, 2024
@aslonnie aslonnie mentioned this issue Nov 15, 2024
Merged
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 21, 2024
@MortalHappiness
[Build][Deps] Remove azure packages from core dependency
426eaa9 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness linked a pull request Nov 21, 2024 that will close this issue
Open
8 tasks
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 21, 2024
@MortalHappiness
[Build][Deps] Remove azure packages from core dependency
bf17b54 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 22, 2024
@MortalHappiness
[Build][Deps] Remove azure packages from core dependency
d0aea09 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 22, 2024
@MortalHappiness
[Build][Deps] Remove azure packages from core dependency
e2bca03 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 22, 2024
@MortalHappiness
[Fix][Build] Fix CI error
3797bb4 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 22, 2024
@MortalHappiness
[Build][Deps] Remove azure packages from core dependency
a6659ae 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 22, 2024
@MortalHappiness
[Fix][Build] Fix CI error
dbb2978 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 22, 2024
@MortalHappiness
[Build][Deps] Remove azure packages from core dependency
2dea592 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 22, 2024
@MortalHappiness
Update requirements_compiled.txt
b7d7501 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 25, 2024
@MortalHappiness
[Build][Deps] Remove azure packages from core dependency
34c99f7 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 25, 2024
@MortalHappiness
Update requirements_compiled.txt
8e88b6c 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Nov 26, 2024
@MortalHappiness
[Build][Deps] Remove azure packages from core dependency
8a28999 
Closes: ray-project#48733
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MortalHappiness MortalHappiness

Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Build][Deps] Add new ray[azure] extra package MortalHappiness/ray
3 participants
@jjyao @MortalHappiness @rynewang