Increase the raylet start wait timeout to accomodate plasma preallocation #15860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
May 18, 2021
python/ray/_private/services.py
Outdated
| # The number of seconds to wait for the Raylet to start. This is normally | ||
| # fast, but when RAY_PREALLOCATE_PLASMA_MEMORY=1 is set, it may take some time | ||
| # (a few GB/s) to populate all the pages on Raylet startup. | ||
| RAYLET_START_WAIT_TIME_S = 120 |
There was a problem hiding this comment.
Why don't do 120 if env.get("RAY_PREALLOCATE_PLASMA_MEMORY") else 5?
There was a problem hiding this comment.
It would be simpler to raise it for everyone (minimal downside), rather than adding such a special case.
There was a problem hiding this comment.
I see. I just thought it would be bad UX if someone needs to wait 120 seconds when there are actual issues (when GCS is actually not connected since it is common among new users). But we anyway writes warning, so I am okay with the current approach.
rkooo567
added
the
@author-action-required
clarkzinzow
approved these changes
May 18, 2021
|
//python/ray/tests:test_multi_node_3 FAILED in 3 out of 3 in 191.3s |
|
The linux wheel build error looks unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When RAY_PREALLOCATE_PLASMA_MEMORY=1, it can take quite some time to preallocate hundreds of GBs of memory. This causes the us to timeout waiting for redis to start. To avoid this problem, increase the default timeout.
Related to #14182