Skip to content

Check if the provider is external before getting the config. #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardliaw merged 5 commits into from
Mar 23, 2018
Merged

Check if the provider is external before getting the config. #1743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb52858
Check if the provider is external before getting the config.
Mar 18, 2018
f71cd3e
Add mock for import.
Mar 18, 2018
cd1f16a
Remove external from DEFAULT_CONFIGS
Mar 18, 2018
ef945ac
Merge branch 'master' into barrachri-fix_1737
richardliaw Mar 19, 2018
39e6c09
dockerize
richardliaw Mar 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/ray/autoscaler/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@


def dockerize_if_needed(config):
if "docker" not in config:
return config
docker_image = config["docker"].get("image")
cname = config["docker"].get("container_name")
if not docker_image:
Expand Down
11 changes: 10 additions & 1 deletion python/ray/autoscaler/node_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,21 @@ def load_aws_config():
ray_aws.__file__), "example-full.yaml")


def import_external():
"""Mock a normal provider importer."""
def return_it_back(config):
return config
return return_it_back, None


NODE_PROVIDERS = {
"aws": import_aws,
"gce": None, # TODO: support more node providers
"azure": None,
"kubernetes": None,
"docker": None,
"local_cluster": None,
"external": None, # Import an external module
"external": import_external # Import an external module
}

DEFAULT_CONFIGS = {
Expand Down Expand Up @@ -71,6 +78,8 @@ def get_node_provider(provider_config, cluster_name):


def get_default_config(provider_config):
if provider_config["type"] == "external":
return {}
load_config = DEFAULT_CONFIGS.get(provider_config["type"])
if load_config is None:
raise NotImplementedError(
Expand Down