-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert pull retry #19068
Revert pull retry #19068
Conversation
This reverts commit 56debfc.
…ition in concurrent chunk receive (ray-project#18955)" This reverts commit d12e35c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigating in #19042
Btw I am not 100% sure yet if this is the root cause, so let’s merge it and see for a couple days. If you can repro it somehow that’d be great too |
Sounds good, let's see if time out will happen again. Currently it is a bit strange that no timeout happens for very similar tests. |
Btw there was a lint failure https://buildkite.com/ray-project/ray-builders-pr/builds/15147#97e71d2b-9614-4830-8ff6-1e7b0ed87192, that I couldn't reproduce in my local env. Do you know why this happens? I've seen this a lot recently. |
@scv119 can you merge the PR after tests are done? |
This is from |
//python/ray/tests:test_client_reconnect is failing on windows, shouldn't be related. |
This reverts commit 83cb992.
Why are these changes needed?
It looks like after these PRs are merged, the dask on ray test starts timeout (this test never times out for last 1 month).
Related issue number
#19042
Checks
scripts/format.sh
to lint the changes in this PR.