Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] add runtime env info to task spec debug string #20631

Merged
merged 3 commits into from
Nov 23, 2021
Merged

[core] add runtime env info to task spec debug string #20631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96148a6
add build task log
SongGuyang Nov 22, 2021
fe3af05
address comments
SongGuyang Nov 22, 2021
155c69a
fix
SongGuyang Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/ray/common/task/task_spec.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,23 @@ std::string TaskSpecification::DebugString() const {
<< "}";
}

// Print runtime env.
if (HasRuntimeEnv()) {
const auto &runtime_env_info = RuntimeEnvInfo();
stream << ", serialized_runtime_env=" << SerializedRuntimeEnv();
const auto &uris = runtime_env_info.uris();
if (uris.size() > 0) {
stream << ", runtime_env_uris=";
for (const auto &uri : uris) {
stream << uri << ":";
}
// Erase the last ":"
stream.seekp(-1, std::ios_base::end);
}
stream << ", runtime_env_eager_install="
<< runtime_env_info.runtime_env_eager_install();
}

return stream.str();
}

Expand Down
4 changes: 3 additions & 1 deletion src/ray/core_worker/core_worker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1864,7 +1864,7 @@ std::vector<rpc::ObjectReference> CoreWorker::SubmitTask(
task_options.serialized_runtime_env);
builder.SetNormalTaskSpec(max_retries, retry_exceptions);
TaskSpecification task_spec = builder.Build();
RAY_LOG(DEBUG) << "Submit task " << task_spec.DebugString();
SongGuyang marked this conversation as resolved.
Show resolved Hide resolved
RAY_LOG(DEBUG) << "Submitting normal task " << task_spec.DebugString();
std::vector<rpc::ObjectReference> returned_refs;
if (options_.is_local_mode) {
returned_refs = ExecuteTaskLocalMode(task_spec);
Expand Down Expand Up @@ -1949,6 +1949,7 @@ Status CoreWorker::CreateActor(const RayFunction &function,
<< "Actor " << actor_id << " already exists";
*return_actor_id = actor_id;
TaskSpecification task_spec = builder.Build();
RAY_LOG(DEBUG) << "Submitting actor creation task " << task_spec.DebugString();
if (options_.is_local_mode) {
// TODO(suquark): Should we consider namespace in local mode? Currently
// it looks like two actors with two different namespaces become the
Expand Down Expand Up @@ -2126,6 +2127,7 @@ std::vector<rpc::ObjectReference> CoreWorker::SubmitActorTask(

// Submit task.
TaskSpecification task_spec = builder.Build();
RAY_LOG(DEBUG) << "Submitting actor task " << task_spec.DebugString();
std::vector<rpc::ObjectReference> returned_refs;
if (options_.is_local_mode) {
returned_refs = ExecuteTaskLocalMode(task_spec, actor_id);
Expand Down