[RLlib] [MultiAgentEnv Refactor #2] Change space types for BaseEnvs and MultiAgentEnvs
#21063
Conversation
avnishn
force-pushed
the
change_env_space_types
branch
from
15869c0 to
5902365
Compare
avnishn
force-pushed
the
change_env_space_types
branch
from
5902365 to
321afc4
Compare
avnishn
force-pushed
the
change_env_space_types
branch
from
9ad419e to
0571a9c
Compare
avnishn
force-pushed
the
change_env_space_types
branch
from
0571a9c to
f96913e
Compare
avnishn
force-pushed
the
change_env_space_types
branch
from
f96913e to
ac2fc52
Compare
avnishn
changed the title
BaseEnvsBaseEnvs
avnishn
changed the title
BaseEnvsBaseEnvs and MultiAgentEnvs
| if not hasattr(self, "_spaces_in_preferred_format") or \ | ||
| self._spaces_in_preferred_format is None: | ||
| self._spaces_in_preferred_format = \ | ||
| self._check_if_space_maps_agent_id_to_sub_space() |
There was a problem hiding this comment.
this is a pure software engineering thing, any reason we don't do this in init but here instead, in a utility function?
There was a problem hiding this comment.
Users will inherit from this class, however they may not necessarily call this function inside of their init functions. If I added this function to init, it may get called before the user has defined their observation/action spaces.
Although calling it here is messy, it allows for a nice external functionality, where if a user defines their spaces in the preferred format, they do not need to implement any of these sampling or checking methods on their own.
rllib/env/base_env.py
Outdated
| The space will either be a gym.space directly corresponding to the | ||
|
|
| if not hasattr(self, "_spaces_in_preferred_format") or \ | ||
| self._spaces_in_preferred_format is None: | ||
| self._spaces_in_preferred_format = \ | ||
| self._check_if_space_maps_agent_id_to_sub_space() |
There was a problem hiding this comment.
Users will inherit from this class, however they may not necessarily call this function inside of their init functions. If I added this function to init, it may get called before the user has defined their observation/action spaces.
Although calling it here is messy, it allows for a nice external functionality, where if a user defines their spaces in the preferred format, they do not need to implement any of these sampling or checking methods on their own.
rllib/env/base_env.py
Outdated
| The space will either be a gym.space directly corresponding to the | ||
|
|
avnishn
force-pushed
the
change_env_space_types
branch
2 times, most recently
from
4c49eae to
d76a8f4
Compare
…ecking obs/actions
avnishn
force-pushed
the
change_env_space_types
branch
from
d76a8f4 to
b2a6033
Compare
Environment's spaces should always be of the format:
{agent_id_1: space_1, agent_id_2 : space_2}in the multi-agent case, andgym.Spacefor non-multi-agent vectorized environments.This differs from a change I made recently where my spaces mapped
{env_id : env.space}. I misunderstood that when a base environment has multiple sub environments, this can only mean that the environment has been vectorized, and not that multiple different types of environments have been initialized in theBaseEnv.Checks
scripts/format.shto lint the changes in this PR.