Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release branch] fix test_catalog.py #22387

Merged
merged 1 commit into from
Feb 15, 2022
Merged

[Release branch] fix test_catalog.py #22387

merged 1 commit into from
Feb 15, 2022

Conversation

mwtian
Copy link
Member

@mwtian mwtian commented Feb 15, 2022

Why are these changes needed?

Fix test_catalog.py on release branch, as suggested by @sven1977 in #21649 (comment)

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

sven1977
sven1977 approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mwtian ! :)

@sven1977 sven1977 merged commit 6882ca0 into ray-project:releases/1.11.0 Feb 15, 2022
@mwtian mwtian deleted the cherrypick-1.11.0rc0-rllib branch February 15, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver gjoliver is a code owner

@avnishn avnishn Awaiting requested review from avnishn avnishn is a code owner

Assignees

@sven1977 sven1977

@gjoliver gjoliver

@zhe-thoughts zhe-thoughts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mwtian @sven1977 @gjoliver @zhe-thoughts