Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve][docs] Document Gradio visualization #28310

Merged
merged 9 commits into from
Jan 24, 2023
Merged

[serve][docs] Document Gradio visualization #28310

merged 9 commits into from
Jan 24, 2023

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Sep 6, 2022

Signed-off-by: Cindy Zhang cindyzyx9@gmail.com

Why are these changes needed?

Documents the new visualization for Serve deployment graphs using Gradio.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@zcin
add docs for gradio visualization
61fe535 
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin
Copy link
Contributor Author

zcin commented Sep 6, 2022

Docs are at https://ray--28310.org.readthedocs.build/en/28310/serve/gradio-dag-visualization.html.

shrekris-anyscale
shrekris-anyscale reviewed Sep 6, 2022
View reviewed changes
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the docs! I left some comments.

@zcin
address comments
65f82ad 
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin zcin marked this pull request as ready for review September 6, 2022 23:12
@zcin zcin added serve Ray Serve Related Issue docs An issue or change related to documentation labels Sep 6, 2022
shrekris-anyscale
shrekris-anyscale approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@simon-mo
Copy link
Contributor

simon-mo commented Sep 7, 2022

@ray-project/ray-docs please assign someone for review?

@richardliaw
Copy link
Contributor

Can we move this to the Serve/Examples section? Seems out of place to put it in user guides.

@stale
Copy link

stale bot commented Oct 8, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 8, 2022
@stale
Copy link

stale bot commented Oct 22, 2022

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Oct 22, 2022
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 22, 2022
@stale
Copy link

stale bot commented Nov 22, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Nov 22, 2022
@stale
Copy link

stale bot commented Dec 11, 2022

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Dec 11, 2022
@stale
Copy link

stale bot commented Dec 26, 2022

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Dec 26, 2022
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Dec 26, 2022
@zcin @richardliaw
Update doc/source/serve/gradio-dag-visualization.md
da76182 
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin zcin requested a review from architkulkarni as a code owner December 29, 2022 23:22
@zcin
Merge branch 'master' into graph_docs
59ec1d2 
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin
Copy link
Contributor Author

zcin commented Dec 29, 2022

Can we move this to the Serve/Examples section? Seems out of place to put it in user guides.

@richardliaw How would you feel about placing it as a subsection here? We can provide users with two options for visualizing their deployment graph.

zcin added 5 commits January 17, 2023 09:24
@zcin
Merge branch 'master' into graph_docs
3d4a5c9 
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin
Merge branch 'master' into graph_docs
71b2abd 
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin
update
6149a47 
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin
fix
26d6dd8 
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin
fix
d9e692a 
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin
Copy link
Contributor Author

zcin commented Jan 23, 2023

@richardliaw Moved to the examples section, PTAL! Docs are here: https://ray--28310.org.readthedocs.build/en/28310/serve/tutorials/gradio-dag-visualization.html.

richardliaw
richardliaw approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@zcin
Copy link
Contributor Author

zcin commented Jan 23, 2023 •
edited
Loading

Windows test_state_api failing on master, unrelated.
Screen Shot 2023-01-23 at 3 43 56 PM

@architkulkarni architkulkarni added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jan 24, 2023
@architkulkarni architkulkarni merged commit e7aabe8 into ray-project:master Jan 24, 2023
@zcin zcin deleted the graph_docs branch January 27, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

@shrekris-anyscale shrekris-anyscale shrekris-anyscale approved these changes

@edoakes edoakes Awaiting requested review from edoakes edoakes is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo

@jiaodong jiaodong Awaiting requested review from jiaodong

@sihanwang41 sihanwang41 Awaiting requested review from sihanwang41

@architkulkarni architkulkarni Awaiting requested review from architkulkarni

Assignees

@zcin zcin

Labels
docs An issue or change related to documentation serve Ray Serve Related Issue tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zcin @simon-mo @richardliaw @shrekris-anyscale @architkulkarni