Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datasets] [Docs] Add seealso to map-related methods #30579

Merged
merged 4 commits into from
Jan 29, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Nov 22, 2022

Signed-off-by: Balaji balaji@anyscale.com

Why are these changes needed?

This PR adds seealso notes to help users distinguish between map, flat_map, and map_batches.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani marked this pull request as draft November 22, 2022 17:38
@stale
Copy link

stale bot commented Dec 31, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Dec 31, 2022
@stale
Copy link

stale bot commented Jan 16, 2023

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Jan 16, 2023
@bveeramani bveeramani assigned bveeramani and unassigned c21 and clarkzinzow Jan 24, 2023
@bveeramani bveeramani reopened this Jan 27, 2023
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jan 27, 2023
@bveeramani bveeramani added stale The issue is stale. It will be closed within 7 days unless there are further conversation and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Jan 27, 2023
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani marked this pull request as ready for review January 27, 2023 00:53
@bveeramani bveeramani assigned c21 and unassigned bveeramani Jan 27, 2023
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@c21
Copy link
Contributor

c21 commented Jan 28, 2023

@richardliaw - could you help merge this? Thanks.

@clarkzinzow clarkzinzow merged commit 112a265 into ray-project:master Jan 29, 2023
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…0579)

This PR adds seealso notes to help users distinguish between map, flat_map, and map_batches.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants